satwik-pachigolla commented on code in PR #18111:
URL: https://github.com/apache/pinot/pull/18111#discussion_r3042131111


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -198,6 +198,29 @@ public MultiStageBrokerRequestHandler(PinotConfiguration 
config, String brokerId
   @Override
   public void start() {
     _queryDispatcher.start();
+    warmupCompile();
+  }
+
+  /**
+   * Best-effort warmup of the Calcite compile pipeline before serving 
traffic. Reduces but does
+   * not guarantee that cold-start compilation times won't breach the timeout 
limit enforced in #14946.

Review Comment:
   Updated comment, I did some more investigation and this was because the 
first queries to hit the broker had 1s overall timeouts so the ~500 ms of 
latency the cold start adds pushed them over the timeout so it's not really 
related to that PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to