Jackie-Jiang opened a new pull request, #18116:
URL: https://github.com/apache/pinot/pull/18116
## Summary
- Delete `SegmentIndexCreationInfo` (trivial wrapper holding only `int
totalDocs`) and `ColumnIndexCreationInfo` (wrapper around `ColumnStatistics` +
3 derivable fields)
- Replace with `int totalDocs` and `ColumnStatistics` directly at all usage
sites
- Simplify `SegmentCreator.init()` signature and consolidate common
initialization into `BaseSegmentCreator`
- The 3 extra fields from `ColumnIndexCreationInfo` are now handled inline:
- `useVarLengthDictionary`: re-derived from `DictionaryIndexConfig` +
column stats
- `isAutoGenerated`: detected via `instanceof DefaultColumnStatistics`
- `defaultNullValue`: computed from `FieldSpec.getDefaultNullValueString()`
## Test plan
- [ ] Existing unit tests pass (`ColumnMetadataTest`,
`SegmentPreProcessorTest`, `SegmentIndexCreationDriverImplTest`)
- [ ] Existing integration tests pass
- [ ] No behavioral change — pure refactoring to remove indirection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
