yashmayya commented on code in PR #18113:
URL: https://github.com/apache/pinot/pull/18113#discussion_r3046265097


##########
pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java:
##########
@@ -114,6 +115,10 @@ private static long getFrequencyInSeconds(ControllerConf 
config) {
 
   @Override
   protected void processTables(List<String> tableNamesWithType, Properties 
periodicTaskProperties) {
+    // Make it so that only one controller is responsible for cleanup.
+    if (!_leadControllerManager.isLeaderForTable(TASK_NAME)) {
+      return;
+    }

Review Comment:
   Good catch, this should be fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to