npawar commented on a change in pull request #4774: Refactor virtualColumn to extraColumn URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r342302017
########## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/immutable/ImmutableSegmentLoader.java ########## @@ -39,13 +41,13 @@ import org.apache.pinot.core.segment.index.loader.SegmentPreProcessor; import org.apache.pinot.core.segment.store.SegmentDirectory; import org.apache.pinot.core.segment.store.SegmentDirectoryPaths; -import org.apache.pinot.core.segment.virtualcolumn.VirtualColumnContext; -import org.apache.pinot.core.segment.virtualcolumn.VirtualColumnProvider; -import org.apache.pinot.core.segment.virtualcolumn.VirtualColumnProviderFactory; import org.apache.pinot.core.startree.v2.store.StarTreeIndexContainer; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import static org.apache.pinot.common.utils.CommonConstants.Schema.VIRTUAL_COLUMN_HOSTNAME; Review comment: Let's remove the static imports from all the files for the sake of readability. Instead use `Schema.VIRTUAL_COLUMN_HOSTNAME` etc, or better `VirtualColumn.HOSTNAME, VirtualColumn.SEGMENT_NAME` etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
