xiangfu0 commented on code in PR #18146:
URL: https://github.com/apache/pinot/pull/18146#discussion_r3063275172
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java:
##########
@@ -69,6 +76,49 @@ protected BaseResultsBlock getNextBlock() {
}
}
+ /// Processes all segments sequentially on the calling thread when only one
task is needed.
Review Comment:
Missing timeout protection. This fast path should respect
`_queryContext.getEndTimeMs()` like the original `mergeResults()` method does.
A hanging segment operator could block indefinitely here without timeout
checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
