xiangfu0 commented on PR #18097: URL: https://github.com/apache/pinot/pull/18097#issuecomment-4222640523
Addressed the legacy-segment rewrite gap called out in review. Changes in this push: - rebased the branch onto current `master` - made `ForwardIndexHandler` treat missing `forwardIndexCompressionCodec` metadata as an unknown legacy state and force a rewrite when the table config now specifies an explicit compression level - tightened `ForwardIndexHandlerTest.testChangeCompressionLevelForSingleColumn()` so it first asserts the old segment has no persisted codec-spec metadata, then verifies the rewrite persists `LZ4(12)` Focused validation run: - `./mvnw -pl pinot-segment-local -am -Dcheckstyle.skip=true -Dtest=ForwardIndexHandlerTest -Dsurefire.failIfNoSpecifiedTests=false test` - `spotless`, `checkstyle`, and `license` checks on `pinot-segment-local` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
