timothy-e commented on code in PR #18139:
URL: https://github.com/apache/pinot/pull/18139#discussion_r3066694525


##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/ServerGrpcChannelBackoffResetHandler.java:
##########
@@ -81,12 +81,12 @@ public synchronized void 
onInstanceConfigChange(List<InstanceConfig> instanceCon
     // isChildChange: an instance ZK node was added or removed under 
/CONFIGS/PARTICIPANT.
     // Both require a full scan to rebuild _shuttingDownServers from the 
current cluster state.
     NotificationContext.Type type = context.getType();
-    if (type == NotificationContext.Type.INIT || context.getIsChildChange()) {
+    String pathChanged = context.getPathChanged();

Review Comment:
   I found the bug and when it was introduced. Updated PR description and the 
change. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to