Jackie-Jiang opened a new pull request, #18170: URL: https://github.com/apache/pinot/pull/18170
## Summary - Refactor `ColumnStatistics` interface: add Javadoc, default methods (`getValueType`, `isSingleValue`, `isFixedLength`, `isAscii`, `getMaxRowLengthInBytes`), move `MapColumnStatistics` to `Utf8Utils` - Clean up stats collectors: rename `BytesColumnPredIndexStatsCollector` → `BytesColumnPreIndexStatsCollector`, extract `EmptyColumnStatistics` for empty columns, simplify `DefaultColumnStatistics` to derive all stats from `FieldSpec` - Enhance `MutableForwardIndex` to track element lengths and ASCII flag, propagated through `MutableColumnStatistics` and `MutableNoDictColumnStatistics` - Improve `CompactedColumnStatistics` and `CompactedNoDictColumnStatistics` to compute all stats (min/max, cardinality, element lengths, ASCII, sorted, row lengths) in a single pass over valid documents - Significantly expand test coverage: add logical type tests (BOOLEAN, TIMESTAMP, JSON), MV tests for all types, assertion ordering aligned with `ColumnStatistics` API, `getLengthOfShortestElement` coverage ## Test plan - [ ] All existing unit tests pass (`pinot-segment-local`, `pinot-segment-spi`) - [ ] New tests: `EmptyColumnStatisticsTest`, `DefaultColumnStatisticsTest`, `MutableNoDictColumnStatisticsTest` - [ ] Enhanced tests: `MutableColumnStatisticsTest`, `CompactedColumnStatisticsTest`, `CompactedNoDictColumnStatisticsTest`, `AbstractColumnStatisticsCollectorTest`, `NoDictColumnStatisticsCollectorTest` 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
