rsrkpatwari1234 commented on PR #18153: URL: https://github.com/apache/pinot/pull/18153#issuecomment-4229472982
> @rsrkpatwari1234 the release candidate for 1.5.0 has already been built -- this patch is only needed for upgrade compatibility right? Is it even useful once servers are able to process `BIGINT` directly? > > > During rolling upgrades (Controller+Broker -> 1.4 and Server -> 1.3), queries that nest CAST(... AS LONG) (→ BIGINT in the plan) under another CAST or under an expression that is the first operand of an outer CAST can fail on older servers because CastTypeAliasRewriter never visited those inner CASTs before dispatch. > > I'm not sure I follow this - `CastTypeAliasRewriter` doesn't even exist in 1.4 (https://github.com/apache/pinot/commits/release-1.4.0/). @yashmayya - We are upgrading pinot from 1.3 -> 1.4 and currently at stage where controllers + brokers are at 1.4 and servers at 1.3 - We cherry-picked #16682 on top of pinot release-1.4.0 to fix issue - `(IllegalArgumentException: Unable to cast expression to type - BIGINT in CastTransformFunction.init)` - Even with #16682, we saw multiple failures for our critical queries since nested CAST is not handled as part of above. - Hence, we need a fix for this to continue upgrade rollouts and ensure backward compatibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
