9aman commented on code in PR #18148:
URL: https://github.com/apache/pinot/pull/18148#discussion_r3092641748
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##########
@@ -591,8 +599,32 @@ private void
updateHybridTableRetentionStrategyEnabled(String newValue) {
}
}
+ private void updateRetentionCreationTimeFallbackEnabled(String newValue) {
+ boolean oldValue = _useCreationTimeFallbackForRetention;
+
+ // Validate that the value is a proper boolean string
+ if (!"true".equalsIgnoreCase(newValue) &&
!"false".equalsIgnoreCase(newValue)) {
Review Comment:
Fixed. Made changes for other config for this class as well.
Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
