siddharthteotia commented on issue #4798: Decouple Key from Record URL: https://github.com/apache/incubator-pinot/pull/4798#issuecomment-550564043 LGTM So all the specific implementation can extend BaseTable and go from there. One thing that remains to be seen is if it is a good idea to pollute TableResizer with overloaded methods to work for both Map<Key,Record> (for group by) or Set<Record> (for distinct) or should we subclass it (to borrow maximum resizing functionality) or write another version of it. Since resizer will be used only by group by and distinct code, probably adding multiple methods that take different data structures should be fine. I can refactor that as part of my pr that adds order by support for distinct -- https://github.com/apache/incubator-pinot/pull/4790
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
