codecov-io commented on issue #4786: Add query options from json to existing query options, instead of overriding URL: https://github.com/apache/incubator-pinot/pull/4786#issuecomment-550595585 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4786?src=pr&el=h1) Report > Merging [#4786](https://codecov.io/gh/apache/incubator-pinot/pull/4786?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/0614310d1916586f0bac6e49ee4f10caee0319cb?src=pr&el=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4786?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4786 +/- ## ========================================== - Coverage 38.13% 37.84% -0.29% ========================================== Files 1209 1211 +2 Lines 64974 65578 +604 Branches 9465 9560 +95 ========================================== + Hits 24776 24821 +45 - Misses 37930 38484 +554 - Partials 2268 2273 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4786?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `75.56% <50%> (+0.17%)` | :arrow_up: | | [...e/pinot/core/io/writer/impl/MmapMemoryManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NbWFwTWVtb3J5TWFuYWdlci5qYXZh) | `0% <0%> (-72.31%)` | :arrow_down: | | [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | :arrow_down: | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | :arrow_down: | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `54.87% <0%> (-13.42%)` | :arrow_down: | | [...core/startree/v2/store/StarTreeIndexContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZUluZGV4Q29udGFpbmVyLmphdmE=) | `68% <0%> (-8%)` | :arrow_down: | | [.../predicate/NotEqualsPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL05vdEVxdWFsc1ByZWRpY2F0ZUV2YWx1YXRvckZhY3RvcnkuamF2YQ==) | `49.25% <0%> (-7.47%)` | :arrow_down: | | [...rEqualitiesToInClauseFilterQueryTreeOptimizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvTXVsdGlwbGVPckVxdWFsaXRpZXNUb0luQ2xhdXNlRmlsdGVyUXVlcnlUcmVlT3B0aW1pemVyLmphdmE=) | `73.33% <0%> (-6.67%)` | :arrow_down: | | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `54.91% <0%> (-5.74%)` | :arrow_down: | | [...pinot/server/realtime/ControllerLeaderLocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VydmVyL3JlYWx0aW1lL0NvbnRyb2xsZXJMZWFkZXJMb2NhdG9yLmphdmE=) | `67.77% <0%> (-5.56%)` | :arrow_down: | | ... and [48 more](https://codecov.io/gh/apache/incubator-pinot/pull/4786/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4786?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4786?src=pr&el=footer). Last update [0614310...ca9ebdd](https://codecov.io/gh/apache/incubator-pinot/pull/4786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
