chenboat commented on code in PR #18419:
URL: https://github.com/apache/pinot/pull/18419#discussion_r3191499854
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/ResourceUsageUtils.java:
##########
@@ -40,4 +42,21 @@ public static long getMaxHeapSize() {
public static long getUsedHeapSize() {
return MEMORY_MX_BEAN.getHeapMemoryUsage().getUsed();
}
+
+ /**
+ * Returns heap bytes used immediately after the last GC, summed across all
memory pools.
+ * More stable than {@link #getUsedHeapSize()} because it excludes
short-lived objects allocated
Review Comment:
If we want to exclude short lived objects, can we use OldGenGC metrics
instead? Is there any documentation on why this method is better than well
known OldGenGC and YoungGenGC methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
