Copilot commented on code in PR #18435:
URL: https://github.com/apache/pinot/pull/18435#discussion_r3199091302
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunction.java:
##########
@@ -79,6 +80,13 @@ default void init(List<TransformFunction> arguments,
Map<String, ColumnContext>
@Nullable
Dictionary getDictionary();
+ /**
+ * Returns the data source backing the transform result when the result maps
directly to a segment data source, or
+ * {@code null} otherwise.
+ */
+ @Nullable
+ DataSource getDataSource();
Review Comment:
Adding a new abstract method to the TransformFunction interface is a
binary-incompatible change for any custom/third-party TransformFunction
implementations (e.g., those registered via TransformFunctionFactory.init from
server config). Older implementations will throw AbstractMethodError when
ColumnContext.fromTransformFunction/TransformOperator calls getDataSource().
Consider making getDataSource() a default method that returns null to preserve
backward compatibility, while still encouraging overrides for functions that
can expose a backing DataSource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
