xiangfu0 commented on code in PR #17269:
URL: https://github.com/apache/pinot/pull/17269#discussion_r3199123454
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/BaseSegmentCreator.java:
##########
@@ -370,10 +370,23 @@ private boolean
createDictionaryForColumn(ColumnStatistics stats, SegmentGenerat
String column = spec.getName();
FieldIndexConfigs fieldIndexConfigs =
config.getIndexConfigsByColName().get(column);
+ // Infer dictionary existence based on index
+ boolean dictionaryRequired =
DictionaryIndexConfig.requiresDictionary(spec, fieldIndexConfigs);
if
(fieldIndexConfigs.getConfig(StandardIndexes.dictionary()).isDisabled()) {
+ if (dictionaryRequired) {
+ LOGGER.warn("Found indexes {} require dictionary, but dictionary is
disabled explicitly.",
Review Comment:
yes, we should always create dictionary if any index requests it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
