xiangfu0 commented on code in PR #18412:
URL: https://github.com/apache/pinot/pull/18412#discussion_r3201306740
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java:
##########
@@ -181,12 +204,28 @@ public EncodingType getEncodingType() {
@Nullable
@Deprecated
+ @JsonIgnore
public IndexType getIndexType() {
- return !_indexTypes.isEmpty() ? _indexTypes.get(0) : null;
+ List<IndexType> indexTypes = getIndexTypes();
+ return indexTypes.isEmpty() ? null : indexTypes.get(0);
}
+ @Deprecated
+ @JsonIgnore
Review Comment:
Adding `@JsonIgnore` here removes `indexType` / `indexTypes` from every
`FieldConfig` serialized through controller APIs and
`TableConfig#toJsonString()`. Those fields are already part of the public JSON
contract, so older clients that still round-trip or inspect them will see a
backward-incompatible response-shape change. Please keep emitting the legacy
fields for now, even if you normalize internally to `indexes`, and deprecate
them over a compatibility window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
