yashmayya commented on code in PR #18288:
URL: https://github.com/apache/pinot/pull/18288#discussion_r3204761078
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -1126,6 +1126,9 @@ public enum Type {
// Parameters related to Hybrid score.
public static final String CONFIG_OF_HYBRID_SCORE_EXPONENT =
CONFIG_PREFIX + ".hybrid.score.exponent";
public static final int DEFAULT_HYBRID_SCORE_EXPONENT = 3;
+ public static final String CONFIG_OF_HYBRID_SCORE_QUEUE_SIZE_OFFSET =
+ CONFIG_PREFIX + ".hybrid.score.queue.size.offset";
+ public static final int DEFAULT_HYBRID_SCORE_QUEUE_SIZE_OFFSET = 0;
Review Comment:
This is confusing, the config is still named
`hybrid.score.queue.size.offset` but the variable name is
`CONFIG_OF_HYBRID_SCORE_QUEUE_FLOOR`? Let's stick to one or the other? 😅
Thinking about it some more - this is a pretty advanced config anyway, so
I'm not totally against `hybrid.score.queue.size.offset` as long as the use
case is documented!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
