Jackie-Jiang commented on code in PR #18471:
URL: https://github.com/apache/pinot/pull/18471#discussion_r3225022933
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageAggregationExecutor.java:
##########
@@ -65,6 +65,10 @@ public MultistageAggregationExecutor(AggregationFunction[]
aggFunctions, int[] f
_mergeResultHolder = null;
} else {
_mergeResultHolder = new Object[numFunctions];
+ for (int i = 0; i < numFunctions; i++) {
+ _mergeResultHolder[i] = aggFunctions[i].extractAggregationResult(
Review Comment:
Why do we need this?
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java:
##########
@@ -205,7 +205,7 @@ public ColumnDataType getFinalResultColumnType() {
@Override
public Long extractFinalResult(Long intermediateResult) {
Review Comment:
Annotate it `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
