xiangfu0 commented on code in PR #18472:
URL: https://github.com/apache/pinot/pull/18472#discussion_r3234070438
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -220,20 +212,16 @@ public TableConfigBuilder
setLineageEntryCleanupRetentionPeriod(String lineageEn
/**
* @deprecated Use {@code segmentIngestionType} from {@link
IngestionConfig#getBatchIngestionConfig()}
*/
+ @Deprecated
public TableConfigBuilder setSegmentPushType(String segmentPushType) {
- if (REFRESH_SEGMENT_PUSH_TYPE.equalsIgnoreCase(segmentPushType)) {
- _segmentPushType = REFRESH_SEGMENT_PUSH_TYPE;
- } else {
- _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
- }
return this;
Review Comment:
These deprecated `pinot-spi` builder setters are still public, but this
change turns them into silent no-ops while Pinot still reads `segmentPushType`
/ `segmentPushFrequency` from the legacy validation config path. Existing
callers that still build configs through `setSegmentPushType()` or
`setSegmentPushFrequency()` will now get different table configs after upgrade
with no compile/runtime signal, so this is a backward-compatibility break
unless the old write-through behavior is preserved or the API fails loudly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
