raghavyadav01 commented on code in PR #18500:
URL: https://github.com/apache/pinot/pull/18500#discussion_r3244003530
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionaryMultiColumnGroupKeyGenerator.java:
##########
@@ -78,7 +80,14 @@ public
NoDictionaryMultiColumnGroupKeyGenerator(BaseProjectOperator<?> projectOp
ExpressionContext groupByExpression = groupByExpressions[i];
ColumnContext columnContext =
projectOperator.getResultColumnContext(groupByExpression);
_storedTypes[i] = columnContext.getDataType().getStoredType();
+ // Only take the dict-id path when the column has a dictionary AND its
forward index is dict-encoded.
+ // A column can have a dictionary alongside a RAW forward index (e.g.
dict + inverted/range), in which case
+ // BlockValSet#getDictionaryIdsSV would route to
ForwardIndexReader#readDictIds and throw on the raw forward
+ // index. Fall back to an on-the-fly dictionary on raw values instead.
Dictionary dictionary = _nullHandlingEnabled ? null :
columnContext.getDictionary();
+ if (dictionary != null && !hasDictEncodedForwardIndex(columnContext)) {
Review Comment:
Are there more code paths which need fixing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
