xiangfu0 commented on PR #18504: URL: https://github.com/apache/pinot/pull/18504#issuecomment-4457165041
Good catch — confirmed in bf6327d21e. Both `ColumnContext.fromDataSource` and `ProjectionBlockValSet.isDictionaryEncoded()` now require `forwardIndex != null && forwardIndex.isDictionaryEncoded()`, so a disabled forward index (dict + inverted/range only) correctly reports `false` and callers fall through to the value/index-based path. Updated the Javadoc to explicitly call out that this is one of two cases where a non-null dictionary still means dict-id reads are not callable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
