jihaozh commented on a change in pull request #4777: [TE] add event driven
scheduler
URL: https://github.com/apache/incubator-pinot/pull/4777#discussion_r343932697
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/DetectionConfigBean.java
##########
@@ -125,6 +127,14 @@ public void setActive(boolean active) {
this.active = active;
}
+ public List<String> getLixFlags() {
Review comment:
Why this is called `LixFlags`? This seems wired to me. `Lix` is an internal
concept and shouldn't be exposed to the opensource project.
Also, looks like we are using it only for availability schedule for now, why
not use a boolean value and call it something like`isEventDrivenSchedule`,
which is more self-explanatory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
