jineshparakh commented on code in PR #18515:
URL: https://github.com/apache/pinot/pull/18515#discussion_r3271657140
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -493,8 +546,10 @@ public void
processSqlQueryWithBothEnginesAndCompareResults(String query, @Suspe
+ "given id on the requested broker. Query may continue to run for a
short while after calling cancel as "
+ "it's done in a non-blocking manner. The cancel method can be called
multiple times.")
@ApiResponses(value = {
- @ApiResponse(code = 200, message = "Success"), @ApiResponse(code = 500,
message = "Internal server error"),
- @ApiResponse(code = 404, message = "Query not found on the requested
broker")
+ @ApiResponse(code = 200, message = "Success"),
+ @ApiResponse(code = 400, message = "Bad Request"),
Review Comment:
The response body already contains the specific error message (e.g.,
"Payload is missing the query string field 'sql'", "Invalid JSON: ...",
"Invalid internal query id: abc"). The @ApiResponse message is a status-code
category label in the Swagger docs, not a per-request error description. "Bad
Request" is the HTTP standard name for 400 and matches the convention used
across all other Pinot Swagger annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
