xiangfu0 opened a new pull request, #18562: URL: https://github.com/apache/pinot/pull/18562
### Summary - Add Checkstyle's `Indentation` rule with Pinot's existing 2-space Java indentation style. - Fix the current Java sources and tests that violated the new indentation rule. - Keep changes mechanical except for small line splits/type simplifications needed to satisfy existing style checks after indentation alignment. ### Why Pinot had many latent indentation inconsistencies because Checkstyle did not enforce Java indentation. This made formatting drift easy to introduce and hard to catch in CI. The new rule makes indentation violations visible during the existing `checkstyle:check` workflow. ### User manual Developers can validate indentation with the normal Checkstyle command: ```bash ./mvnw checkstyle:check -DskipTests -fae ``` For module-level iteration, run: ```bash ./mvnw -pl <module> checkstyle:check -DskipTests ``` ### Sample table config / queries N/A. This PR only changes source formatting enforcement and existing Java indentation; it does not change Pinot runtime table configuration or query behavior. ### Validation - `./mvnw checkstyle:check -DskipTests -fae` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
