akshayrai commented on a change in pull request #4777: [TE] add event driven
scheduler
URL: https://github.com/apache/incubator-pinot/pull/4777#discussion_r343919162
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/TaskManagerImpl.java
##########
@@ -82,6 +88,19 @@ public Long save(TaskDTO entity) {
return findByPredicate(predicate);
}
+ @Override
+ public List<TaskDTO> findByNameOrderByCreateTime(String name, boolean asc) {
Review comment:
This method seems to be truncating the results and it is not very apparent
from the method name.
Should we pass the limit as a parameter? Moreover, you seem to require only
the latest task in your method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
