rseetham commented on PR #18433: URL: https://github.com/apache/pinot/pull/18433#issuecomment-4556950368
+1 to both suggestions from @Jackie-Jiang and @noob-se7en. Beyond the correctness and code quality problems already mentioned, there’s another operational concern worth raising: topic deletion. While the current design does allow deleting a topic in the middle, doing so breaks segment ordering — if the 10000-range partitions are removed, the 20000-range partitions shift down to take their place, causing incorrect segment mapping. This makes mid-sequence topic deletion effectively unsafe in practice. Only deleting the final topic is actually safe. And even then, we have to manually clean up the segments for the topic. Of the two options, the first (encoding partition_id as x_y) seems preferable. The logical table approach does solve the problem today, but it shifts the burden of managing multiple physical tables onto the user. Having this handled natively would be a much cleaner experience imo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
