xiangfu0 commented on code in PR #18588:
URL: https://github.com/apache/pinot/pull/18588#discussion_r3316419347
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/JsonIndexDistinctOperator.java:
##########
@@ -589,34 +466,6 @@ protected String getExplainName() {
@Override
protected void explainAttributes(ExplainAttributeBuilder attributeBuilder) {
super.explainAttributes(attributeBuilder);
- List<ExpressionContext> selectExpressions =
_queryContext.getSelectExpressions();
- if (!selectExpressions.isEmpty()) {
- attributeBuilder.putStringList("keyColumns",
- List.of(selectExpressions.get(0).toString()));
- }
- }
-
- /**
- * Returns true if the expression is the 3/4-arg scalar jsonExtractIndex
form on a column with JSON index and the
- * path is indexed. For OSS JSON index all paths are indexed. For composite
JSON index, only paths in
- * invertedIndexConfigs are indexed per key.
- */
- public static boolean canUseJsonIndexDistinct(IndexSegment indexSegment,
ExpressionContext expr) {
Review Comment:
Regression: the previous working query which fallback to default scan-based
operator will now fail.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/JsonIndexDistinctOperator.java:
##########
@@ -589,34 +466,6 @@ protected String getExplainName() {
@Override
protected void explainAttributes(ExplainAttributeBuilder attributeBuilder) {
super.explainAttributes(attributeBuilder);
- List<ExpressionContext> selectExpressions =
_queryContext.getSelectExpressions();
- if (!selectExpressions.isEmpty()) {
- attributeBuilder.putStringList("keyColumns",
- List.of(selectExpressions.get(0).toString()));
- }
- }
-
- /**
- * Returns true if the expression is the 3/4-arg scalar jsonExtractIndex
form on a column with JSON index and the
- * path is indexed. For OSS JSON index all paths are indexed. For composite
JSON index, only paths in
- * invertedIndexConfigs are indexed per key.
- */
- public static boolean canUseJsonIndexDistinct(IndexSegment indexSegment,
ExpressionContext expr) {
Review Comment:
Regression: the previous working query which fallback to default scan-based
operator will now fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
