xiaohui-sun commented on a change in pull request #4803: [TE] Set non additive
flag for Pinot dataset
URL: https://github.com/apache/incubator-pinot/pull/4803#discussion_r344378321
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/auto/onboard/ConfigGenerator.java
##########
@@ -92,6 +95,16 @@ private static TimeGranularity
getExpectedDelayFromTimeunit(TimeUnit timeUnit) {
return expectedDelay;
}
+ /**
+ * Check if the dataset is non-additive. If it is, set the additive flag to
false and set the pre-aggregated keyword.
+ * @param dataset the dataset DTO to check
+ */
+ static void checkNonAdditive(DatasetConfigDTO dataset) {
+ if (dataset.isAdditive() && dataset.getDataset().endsWith(NON_ADDITIVE)) {
Review comment:
I don't understand the logic here.
So by default the dataset is additive()?
If so then why we need this dataset.isAdditive() check?
If it is one-time fix suggest not to put it into the onboard logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
