st-omarkhalid commented on PR #18602: URL: https://github.com/apache/pinot/pull/18602#issuecomment-4564228851
Good call — moved off the interface. Latest push: - Removed the `default String getServerStats()` from `BrokerResponse`. - Removed `@Override` from `BrokerResponseNative.getServerStats()`. `serverStats` now lives only on `BrokerResponseNative` (the SSE response class), mirroring how `BrokerResponseNativeV2` keeps its MSE-only `getNumGroups()` / `getStageStats()` / `getMaxRowsInJoin()` / `getMaxRowsInWindow()` off the interface. Callers that want to read the field must hold a concrete `BrokerResponseNative` reference and call its getter directly — same asymmetry as `setMaterializedViewQueried`. Tests still 8/8 pass; checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
