rohityadav1993 commented on code in PR #18608:
URL: https://github.com/apache/pinot/pull/18608#discussion_r3318749336
##########
pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java:
##########
@@ -163,6 +166,19 @@ void initializeZK() {
void initializeMetricsReporter() {
LOGGER.info("Initializing metrics reporter");
+ try {
+ ServerConf serverConf = new ServerConf(_pinotConfig);
+ PinotMetricsRegistry metricsRegistry =
PinotMetricUtils.getPinotMetricsRegistry(serverConf.getMetricsConfig());
+ ServerMetrics serverMetrics =
+ new ServerMetrics(serverConf.getMetricsPrefix(), metricsRegistry,
serverConf.emitTableLevelMetrics(),
+ serverConf.getAllowedTablesForEmittingMetrics());
+ serverMetrics.initializeGlobalMeters();
+ ServerMetrics.register(serverMetrics);
Review Comment:
This returns a boolean based on success to register, let's check that and
log if we were able register or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
