wolfkill opened a new pull request, #18626:
URL: https://github.com/apache/pinot/pull/18626

   ## Summary
   
   - Return `false` from `HadoopPinotFS.isDirectory()` when the target path 
does not exist
   - Add a regression test covering the missing-path behavior
   
   ## Rationale
   
   `HadoopPinotFS.isDirectory()` used `FileSystem#getFileStatus()` directly, so 
missing paths raised `FileNotFoundException`. Other filesystem implementations 
such as `LocalPinotFS` treat missing paths as not directories. This makes the 
Hadoop implementation consistent for callers that use `isDirectory()` as a 
predicate.
   
   Addresses #7083.
   
   ## Test Plan
   
   - `./mvnw -pl pinot-plugins/pinot-file-system/pinot-hdfs -am 
-Dtest=HadoopPinotFSTest#testIsDirectoryReturnsFalseForNonExistentPath 
-Dsurefire.failIfNoSpecifiedTests=false test`
   - `./mvnw -pl pinot-plugins/pinot-file-system/pinot-hdfs -am 
-Dtest=HadoopPinotFSTest -Dsurefire.failIfNoSpecifiedTests=false test`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to