timothy-e opened a new pull request, #18636: URL: https://github.com/apache/pinot/pull/18636
### Summary Appends 44 timezone entries to `pinot-common/src/main/resources/zone-index.properties`. The entries cover: - `America/Coyhaique` - `Etc/GMT`, `Etc/GMT+0` through `Etc/GMT+12`, `Etc/GMT-0` through `Etc/GMT-14`, `Etc/GMT0` - `Etc/Greenwich`, `Etc/UCT`, `Etc/UTC`, `Etc/Universal`, `Etc/Zulu` - `GMT`, `GMT+0`, `GMT-0`, `GMT0`, `Greenwich` - `UCT`, `Universal`, `Zulu` `EST`, `HST`, `MST`, `Factory`, and `US/Pacific-New` remain excluded, consistent with the existing comments in the file noting they are absent from `java.time` or removed from tzdata. Stripe's timezone allowlist includes these timezone IDs, but they were absent from `zone-index.properties`, meaning Pinot would reject them as unrecognized timezone identifiers when used in queries. ### Testing The timezones in this file are supposed to be compatible with `java.util.Timezone`, `java.time.ZoneId`, and `jodatime`, but nothing actually ensured that. I could manually check, but it's nice to have real validation. Adds a new `TimeZoneKeyTest` class that validates all timezones listed in `zone-index.properties` are recognized by three timezone libraries: - `java.util.TimeZone` - `java.time.ZoneId` - Joda-Time's `DateTimeZone` The tests collect all unsupported timezones before failing, so a single test run surfaces every incompatible entry rather than stopping at the first failure. Also includes basic sanity checks that the zone index file is non-empty and that the UTC key is present with key 0. (I'm not sure why `zone-index.properties` has timezones like `-13:52`, as they're not compatible with `java.util.TimeZone`. For now, I've just skipped them in the `java.util.Timezone` test`.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
