gortiz commented on code in PR #18648:
URL: https://github.com/apache/pinot/pull/18648#discussion_r3341715401
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNativeV2.java:
##########
@@ -54,6 +55,8 @@
"pools", "rlsFiltersApplied", "groupsTrimmed"
})
public class BrokerResponseNativeV2 implements BrokerResponse {
+ private static final String EARLY_TERMINATION_REASON_SEPARATOR = ",";
Review Comment:
I don't think using ',' as a separator is a good choice. Granted that each
reason is a single word, but if, in the future, we want to include more
context, that comma will be problematic. What about something not as common in
English but still easy to read as |?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
