xiangfu0 commented on PR #17939:
URL: https://github.com/apache/pinot/pull/17939#issuecomment-4607200209
Resolving the outstanding review threads in commit 4795385199:
- **Design docs (`docs/design/sql-insert/*`)** — removed. They were
aspirational v2 design notes (NEW/PREPARED/COMMITTED/GC states,
`WAIT_FOR_VISIBLE`, segment-replacement publish, `?table=` params, column-less
`INSERT INTO VALUES`, comma-separated `SET`) that did not match the shipped v1
surface. The ~39 accuracy comments on them are addressed by removal; v1
behavior is documented inline in the code.
- **`/insert/complete` error message** — now references the actual path
`/insert/complete/{statementId}`.
- **`BaseControllerStarter` disabled-feature comment/log** — corrected: when
`controller.insert.enabled=false`, the REST surface returns HTTP 503 and
in-process submit returns `COORDINATOR_NOT_READY` (not `NO_EXECUTOR`).
- **Threads on `FileInsertArtifactPublisher` / `InsertRowApplier` /
`LocalShardLog` / `RowInsertExecutor`** — those files belonged to the earlier
shard-log architecture that was replaced by the controller-coordinator design;
the files no longer exist in this PR and the concerns (UTF-8 charset,
metadata-write locking, abort rollback) were addressed in the replacement.
- **`SqlInsertIntoValues` qualified-name unparse** — addressed earlier; the
path now emits a single combined `SqlIdentifier` via
`UnparseUtils.combineIdentifiers`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
