xiangfu0 commented on code in PR #18660:
URL: https://github.com/apache/pinot/pull/18660#discussion_r3348371720
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -402,6 +404,7 @@ public static long getRandomInitialDelayInSeconds() {
public static final int DEFAULT_DELETED_SEGMENTS_RETENTION_IN_DAYS = 7;
public static final int DEFAULT_TABLE_MIN_REPLICAS = 1;
public static final int DEFAULT_JERSEY_ADMIN_PORT = 21000;
+ public static final boolean DEFAULT_INGEST_FROM_URI_ALLOW_LOCAL_FILE_SYSTEM
= false;
Review Comment:
Defaulting this new flag to `false` changes existing `/ingestFromURI`
behavior on upgrade: deployments that currently ingest from controller-local
`file:` or scheme-less paths will start failing without any config change. For
a config whose purpose is to disable local-file ingestion, the
backward-compatible rollout is to preserve the current behavior by default and
let operators opt out explicitly first, then flip the default later with a
documented upgrade note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
