xiangfu0 commented on code in PR #18665:
URL: https://github.com/apache/pinot/pull/18665#discussion_r3358892998
##########
pinot-materialized-view/src/main/java/org/apache/pinot/materializedview/executor/GrpcMaterializedViewQueryExecutor.java:
##########
@@ -219,6 +219,18 @@ private void decodeNextFrame() {
}
}
+ /// Prefixes a `SET enableMaterializedViewRewrite = 'false'` statement onto
the materialization
+ /// query. The query reads the base table, and with broker-wide MV rewrite
enabled it would
+ /// otherwise be eligible to be rewritten back onto an MV over the same base
table (its own MV or
+ /// a sibling), which would build the MV from MV data instead of the base
table. The opt-out is
+ /// honored from user input (it only forgoes an optimization, never changes
results), so a plain
+ /// SET prefix is sufficient.
+ @VisibleForTesting
+ static String disableMaterializedViewRewrite(String sql) {
Review Comment:
if user already has the query option then this override won't work.
if you want to change the default behavior then better just hard-coded it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
