mayankshriv commented on a change in pull request #4807: Include dataSchema in
the ResultTable to retain column type information
URL: https://github.com/apache/incubator-pinot/pull/4807#discussion_r344981209
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##########
@@ -220,9 +221,9 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
// Parse the option from request whether to preserve the type
Map<String, String> queryOptions = brokerRequest.getQueryOptions();
- String preserveTypeString =
- (queryOptions == null) ? "false" :
queryOptions.getOrDefault(QueryOptionKey.PRESERVE_TYPE, "false");
- boolean preserveType = Boolean.valueOf(preserveTypeString);
+ boolean preserveType = QueryOptionsUtils.isPreserveType(queryOptions);
Review comment:
This seems like cleanup items that are not really needed for using
DataSchema in ResultTable. If so, just call it out in the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
