lazyfetch commented on issue #18221: URL: https://github.com/apache/pinot/issues/18221#issuecomment-4640622644
Hi @xiangfu0 , before I open the PR, wanted to confirm scope `KafkaConfluentSchemaRegistryProtoBufMessageDecoder` already covers registry-backed resolution, so adding it to the base decoder would either duplicate that logic or pull in a Confluent dependency where there isn't one today. I'm inclined to replace the TODO with a clear doc comment + error message pointing users to the right decoder, backed by a unit test Is that the direction you had in mind, or would you prefer full registry integration in the base decoder? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
