Akanksha-kedia opened a new pull request, #18700: URL: https://github.com/apache/pinot/pull/18700
## Description `ServerInstance.toServerRoutingInstance(TableType, boolean preferNettyTls)` is `@Deprecated` in favour of `toServerRoutingInstance(TableType, RoutingType)`. This PR migrates all three production call-sites to the typed overload. ### Changes | File | Before | After | |---|---|---| | `QueryRouter` | `toServerRoutingInstance(…, true/false)` | `toServerRoutingInstance(…, NETTY_TLS / NETTY)` | | `ImplicitHybridTableRouteInfo` | `toServerRoutingInstance(…, preferTls)` | resolve `RoutingType` once before loop, pass enum | | `LogicalTableRouteInfo` | `toServerRoutingInstance(…, preferTls)` | same pattern | `GrpcBrokerRequestHandler` already uses `RoutingType.GRPC` and is unaffected. The deprecated overload and its test coverage in `QueryRoutingTest` are left for a follow-up removal PR once all callers are migrated. ## Checklist - [x] No behaviour change — `true → NETTY_TLS`, `false → NETTY` - [x] Consistent with `GrpcBrokerRequestHandler` which already uses the new API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
