Akanksha-kedia opened a new pull request, #18713:
URL: https://github.com/apache/pinot/pull/18713

   ## Description
   
   `getParticipantInstanceIdFromExternalView` in 
`PinotLeadControllerRestletResource` guards against a null `ExternalView`, but 
immediately dereferences the result of 
`ExternalView.getStateMap(partitionName)` without a null check. `getStateMap` 
can return `null` when a partition has not yet been assigned in the lead 
controller resource external view (e.g. during controller initialisation or a 
leader transition), causing a `NullPointerException`.
   
   **Fix:** add a null check with a `WARN` log before iterating the partition 
state map, returning `null` (no leader found) — consistent with the existing 
null-EV guard pattern in the same method.
   
   ## Related
   Same family of fixes as #18697 (DebugResource), #18455 (HelixHelper).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to