gortiz commented on PR #18696: URL: https://github.com/apache/pinot/pull/18696#issuecomment-4658556336
Thanks for the careful review @yashmayya! Good catch on the uniform-vs-divergent case — pushed a follow-up that addresses it (66e76097fa). Rather than conditionally emitting the `Alternative` wrapper only when a server has >1 distinct plan, the simplifier now **always** wraps each group in `Alternative(segments=N)` — including the single-group case. That way a uniform server also contributes an `Alternative`, so it pairs with and folds into the matching group of a divergent server (and the `segments` counts sum as before). A final `removeRedundantAlternatives` pass runs after all servers are merged and strips any `Alternative` that is the sole child of its combine, so the common all-segments-share-a-plan case renders exactly as before — no existing test output changes. Added unit tests for the cross-server fold (`uniformServerFoldsIntoDivergentServerAcrossServers`) and the unwrap pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
