deepthi912 commented on code in PR #18637:
URL: https://github.com/apache/pinot/pull/18637#discussion_r3385029212
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/BaseSegmentCreator.java:
##########
@@ -867,8 +867,14 @@ private void buildStarTreeV2IfNecessary(File indexDir)
if (CollectionUtils.isNotEmpty(starTreeIndexConfigs) ||
enableDefaultStarTree) {
MultipleTreesBuilder.BuildMode buildMode =
_config.isOnHeap() ? MultipleTreesBuilder.BuildMode.ON_HEAP :
MultipleTreesBuilder.BuildMode.OFF_HEAP;
+ // Pass IndexLoadingConfig so downstream readers (e.g. external-table
forward-index readers
Review Comment:
Makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
