Akanksha-kedia commented on code in PR #18514:
URL: https://github.com/apache/pinot/pull/18514#discussion_r3387703011
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/JoinNode.java:
##########
@@ -118,6 +118,6 @@ public int hashCode() {
}
public enum JoinStrategy {
- HASH, LOOKUP, ASOF
+ HASH, LOOKUP, ASOF, BROADCAST_RIGHT
Review Comment:
Fixed in the latest commit. `BROADCAST_RIGHT = 3` is now added to
`plan.proto`'s `JoinStrategy` enum, and
`PlanNodeSerializer.convertJoinStrategy()` and
`PlanNodeDeserializer.convertJoinStrategy()` both have the new case.
`DefaultJoinOperatorFactory` handles `BROADCAST_RIGHT` alongside `HASH` (same
`HashJoinOperator` — the broadcast distribution was a planning-time decision).
`InStageStatsTreeBuilder.visitJoin` was also fixed to remove the fragile assert
and handle all strategies correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
