cristianpop commented on PR #18729: URL: https://github.com/apache/pinot/pull/18729#issuecomment-4708023231
@gortiz Thank you for looking over it and for the suggestions! Sorry it took so long for me to respond and for the obvious issues that escaped. I'm having some environment-related issues at the moment and it makes it hard to test the changes. I fixed the UTs and I implemented a few integration tests as you suggested. I chose to reuse the NullHandlingIntegration test setup and dataset and built a few queries around it. Please let me know if that's ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
