spapin commented on code in PR #18738: URL: https://github.com/apache/pinot/pull/18738#discussion_r3414686381
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ########## Review Comment: Here, we add all the records to _docIdMapping. On line 138, the call to Utf8.encodedLength may crash the function before `_postingListMap` is also increased. This is the source of the discrepancy between the json index and the mapped docId. Fixing the estimator ensures the issue doesn't happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
