xiangfu0 commented on PR #18668: URL: https://github.com/apache/pinot/pull/18668#issuecomment-4712226231
Addressed the remaining update-path/compatibility-verifier notes in the rebased head `864cfa1221` while keeping the intentional hard-reject behavior: - Added `TableConfigsRestletResourceTest#testUpdateRejectsStoredLegacyFieldLevelEncodingType`, which seeds a legacy stored config and verifies a new-controller table-config update rejects field-level `encodingType` with the migration message. - Updated the top-level README to state that create/update validation rejects `fieldConfigList[].encodingType` and that existing configs must be migrated before submission. - Added a compatibility-verifier README note explaining why those fixtures intentionally keep field-level `encodingType`: they are submitted to the older controller before the upgrade, where `fieldConfigList[].indexes.forward.encodingType` is not understood. They are not examples for configs submitted to new controllers. Local validation: - `./mvnw -pl pinot-controller -am -Dtest=TableConfigsRestletResourceTest#testUpdateRejectsStoredLegacyFieldLevelEncodingType -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw spotless:apply -pl pinot-controller` - `./mvnw license:format -pl pinot-controller` - `./mvnw checkstyle:check -pl pinot-controller` - `./mvnw license:check -pl pinot-controller` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
