vincentchenjl commented on a change in pull request #4814: [TE][notification]
Minor cleaning up of the jira related code
URL: https://github.com/apache/incubator-pinot/pull/4814#discussion_r345512347
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/commons/ThirdEyeJiraClient.java
##########
@@ -61,30 +61,36 @@ private JiraRestClient
createJiraRestClient(JiraConfiguration jiraAdminConfig) {
jiraAdminConfig.getJiraPassword());
}
- /**
- * Search for all the existing jira tickets based on the filters
- */
- public List<Issue> getIssues(String project, List<String> labels, String
reporter, long lookBackMillis) {
- List<Issue> issues = new ArrayList<>();
-
+ private String buildQueryOnCreatedBy(long lookBackMillis) {
long lookBackDays = TimeUnit.MILLISECONDS.toDays(lookBackMillis);
String createdByQuery = "created";
- if (lookBackDays <= 0) {
+ if (lookBackDays < 0) {
Review comment:
Can `lookbackDays` be negative? In what case it is negative?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
