Akanksha-kedia commented on code in PR #18472:
URL: https://github.com/apache/pinot/pull/18472#discussion_r3420870595
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -220,20 +212,16 @@ public TableConfigBuilder
setLineageEntryCleanupRetentionPeriod(String lineageEn
/**
* @deprecated Use {@code segmentIngestionType} from {@link
IngestionConfig#getBatchIngestionConfig()}
*/
+ @Deprecated
public TableConfigBuilder setSegmentPushType(String segmentPushType) {
- if (REFRESH_SEGMENT_PUSH_TYPE.equalsIgnoreCase(segmentPushType)) {
- _segmentPushType = REFRESH_SEGMENT_PUSH_TYPE;
- } else {
- _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
- }
return this;
Review Comment:
Updated in the latest commit. The write-through now also handles the case
where a BatchIngestionConfig already exists: it merges _segmentPushType into
segmentIngestionType and _segmentPushFrequency into segmentIngestionFrequency
only when those fields are not yet set. An explicit withIngestionConfig() call
still takes precedence. @xiangfu0 @Jackie-Jiang could you re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
