anuragrai16 commented on code in PR #18725:
URL: https://github.com/apache/pinot/pull/18725#discussion_r3421655614
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -277,7 +277,15 @@ private QueryEnvironment.QueryPlannerResult
getQueryPlannerResult(PlannerContext
extraFields.put(RuleTimingPlannerListener.RULE_TIMINGS,
plannerContext.getPlannerOutput().get(RuleTimingPlannerListener.RULE_TIMINGS));
}
- return new QueryPlannerResult(dispatchableSubPlan, explainStr, tableNames,
extraFields);
+ boolean liteModeImplicitSortApplied = false;
+ int liteModeEffectiveSortLimit = -1;
+ PhysicalPlannerContext physicalPlannerContext =
plannerContext.getPhysicalPlannerContext();
+ if (physicalPlannerContext != null &&
physicalPlannerContext.isLiteModeImplicitSortApplied()) {
+ liteModeImplicitSortApplied = true;
+ liteModeEffectiveSortLimit =
physicalPlannerContext.getLiteModeEffectiveSortLimit();
+ }
+ return new QueryPlannerResult(dispatchableSubPlan, explainStr, tableNames,
extraFields,
Review Comment:
Good point. Using only `liteModeEffectiveSortLimit` everywhere now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
