xiangfu0 commented on PR #18785: URL: https://github.com/apache/pinot/pull/18785#issuecomment-4725619302
Closing in favor of #18784, which covers the same server-local realtime OOM protection but is the more complete and lower-risk implementation: - **Per-table override** (`ingestionConfig.streamIngestionConfig.serverIngestionOomProtectionConfig`: ENABLE/DISABLE/per-table thresholds) on top of server-level config — which this PR lacked. - **Table-manager-owned lifecycle**: #18784 creates the protection manager per `RealtimeTableDataManager` (reconstructed on table reload, disposed with the table), which is safer for server restart and in-process test reuse than this PR's process-wide singleton + daemon thread. - No upsert SPI change / primary-key-cap surface (this PR's removed, but #18784 never needed it). - Same safety properties (pauses only in INITIAL_CONSUMING, idle-timer reset on resume, stop-aware wait), plus a per-table heap-usage-% metric and docs. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
